EPFL svg official icons #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added EPFL official icons to the Styleguide
package.json
Outdated
| @@ -169,6 +169,7 @@ | |||
| "jquery-mousewheel": "^3.1.13", | |||
| "multiple-select": "^1.5.2", | |||
| "object-fit-images": "^3.2.4", | |||
| "package.json": "^2.0.1", | |||
There was a problem hiding this comment.
C'est bizarre ce changement.
There was a problem hiding this comment.
Plus rien ne fonctionnait en local, j'ai donc du faire un npm install package.json
Pourquoi ça a ajouté cette ligne, aucune idée. Toujours est-il que c'est supprimé
There was a problem hiding this comment.
Oui, il y a toujours le problème. Les tests ne passent pas.
Il y a un conflit entre yarn.lock et package-lock.json.
Tu peux supprimer le fichier package-lock.json et annuler tous les changements du yarn.lock.
Correction commentaire #672 (review)
-deleted package-lock.json - revert changes yarn.lock
|
🔎 Download the Backstop report for this pull request (link valid for 90 days): |
williambelle
approved these changes
Jul 17, 2023
alinekeller
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated and new icons branch, reloaded.